Skip to content

speed up nvte_multi_padding / nvte_multi_unpadding#592

Merged
matthiasdiener merged 11 commits into
devfrom
mdiener/speedup-pad-unpad
Jun 7, 2026
Merged

speed up nvte_multi_padding / nvte_multi_unpadding#592
matthiasdiener merged 11 commits into
devfrom
mdiener/speedup-pad-unpad

Conversation

@matthiasdiener
Copy link
Copy Markdown
Contributor

@matthiasdiener matthiasdiener commented May 20, 2026

Description

Please include a brief summary of the changes, relevant motivation and context.

Fixes https://github.com/ROCm/frameworks-internal/issues/16530

See https://github.com/ROCm/frameworks-internal/issues/16530#issuecomment-4502138388 for performance.

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Changes

Please list the changes introduced in this PR:

  • Change A
  • Change B

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@matthiasdiener matthiasdiener self-assigned this May 20, 2026
@matthiasdiener matthiasdiener added the ci-level 1 CI test level 1 label May 20, 2026
@matthiasdiener matthiasdiener marked this pull request as ready for review May 20, 2026 20:01
Comment thread transformer_engine/common/util/padding.cu Outdated
Comment thread transformer_engine/common/util/padding.cu
Comment thread transformer_engine/common/util/padding.cu Outdated
@matthiasdiener matthiasdiener requested a review from aris134 June 1, 2026 19:59
Copy link
Copy Markdown
Contributor

@aris134 aris134 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment thread transformer_engine/common/util/padding.cu Outdated
Comment thread transformer_engine/common/util/padding.cu
@matthiasdiener matthiasdiener requested a review from alextmagro June 5, 2026 17:38
@matthiasdiener matthiasdiener added ci-level 3 CI test level 3 and removed ci-level 1 CI test level 1 labels Jun 5, 2026
@matthiasdiener matthiasdiener added ci-level 1 CI test level 1 and removed ci-level 3 CI test level 3 labels Jun 6, 2026
@matthiasdiener matthiasdiener merged commit 6ac5195 into dev Jun 7, 2026
54 of 63 checks passed
@matthiasdiener matthiasdiener deleted the mdiener/speedup-pad-unpad branch June 7, 2026 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-level 1 CI test level 1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants